Skip to content

Conversation

jif-oai
Copy link
Contributor

@jif-oai jif-oai commented Oct 7, 2025

Check on STDOUT / STDERR or aggregated output for some logs when sanbox is denied

@jif-oai
Copy link
Contributor Author

jif-oai commented Oct 8, 2025

@codex fix the tests

Copy link
Contributor

Summary

  • Updated sandbox denied UI messaging to combine stdout and stderr when aggregated text is missing, added explicit stdout-only coverage, and expanded regression tests for the sandbox error message helper. codex-rs/core/src/error.rsL310-L441
  • Simplified sandbox denial keyword scanning to check stdout, stderr, and aggregated streams individually without building an intermediate joined buffer. codex-rs/core/src/exec.rsL200-L233

Testing

  • ⚠️ cargo test -p codex-core (fails: unable to download crates from crates.io in the sandbox).
  • ⚠️ cargo test -p codex-core --offline (fails: cargo still needs the tree-sitter crate while offline).
  • ⚠️ just fix -p codex-core (fails: crate download blocked in the sandbox).

View task →

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants