fix: tui launch latency by disabling osc probe #4912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ae-openai
commented
Oct 8, 2025
ae-openai
commented
- Codex CLI startup slowed to ~1.5 s in Terminal and Ghostty.
- This was because because Tui::new requested the terminal’s 256-color palette via OSC 4. Trace logging showed the constructor waiting for 1.5s at query_terminal_palette before timing out, since many modern GPU terminals ignore OSC 4/10/11.
- This is a minimal change that disables those probes, but keeps it easy to bring the back for specific terminals that support it like iTerm or xterm, or with different more performant approach.
- Codex CLI startup slowed to ~1.5 s in Terminal and Ghostty. - This was because because Tui::new requested the terminal’s 256-color palette via OSC 4. Trace logging showed the constructor waiting for 1.5s at query_terminal_palette before timing out, since many modern GPU terminals ignore OSC 4/10/11. - This is a minimal change that disables those probes, but keeps it easy to bring the back for specific terminals that support it like iTerm or xterm, or with different more performant approach.
bolinfest
requested changes
Oct 8, 2025
| use std::sync::Mutex; | ||
| use std::sync::OnceLock; | ||
|
|
||
| const TERMINAL_QUERIES_ENABLED: bool = false; |
There was a problem hiding this comment.
If query_terminal_palette() is really the issue, then I would rather exit early there.
Rather than categorically disable, we could call:
codex/codex-rs/core/src/terminal.rs
Line 24 in abd5170
and if that value isn't a "known fast" terminal (like iTerm), then we return Err?
There was a problem hiding this comment.
Maybe check if the value from detect_terminal() starts with "iTerm.app" for now?
It's nice not to have unreachable code sitting around.
|
See #4913 for an example of my proposed changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.