Skip to content

fix: tui launch latency by disabling osc probe #4913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+6 −0
Closed

fix: tui launch latency by disabling osc probe #4913

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions codex-rs/tui/src/terminal_palette.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,12 @@ mod imp {
return Ok(None);
}

// Many modern GPU terminals ignore OSC, so only perform the query on
// terminals known to support it.
if !codex_core::terminal::user_agent().starts_with("iTerm.app") {
return Ok(None);
}
Comment on lines +107 to +111
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"ignore OSC" doesn't make sense; there are a large number of OSC codes and different terminals respond to different subsets of them.


let mut tty = match OpenOptions::new().read(true).write(true).open("/dev/tty") {
Ok(file) => file,
Err(_) => return Ok(None),
Expand Down
Loading