Stream active execs in transcript mode #4916
Conversation
dedrisian-oai
changed the base branch from
main
to
daniel/fix-transcript-lines-tab-char
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
|
|
||
| pub(crate) fn handle_mcp_begin_now(&mut self, ev: McpToolCallBeginEvent) { | ||
| self.flush_answer_stream_with_separator(); | ||
| if self.transcript_mode_active { | ||
| // In transcript mode, don't create an active cell; history will be | ||
| // emitted on the corresponding end event. | ||
| self.request_redraw(); | ||
| return; | ||
| } |
There was a problem hiding this comment.
While transcript_mode_active is true, handle_exec_begin_now (and the analogous MCP handler) returns before creating an active_cell. When the user closes the transcript overlay, close_transcript_overlay only flips the flag back to false; it never reconstructs an active cell for any command that began during transcript mode. As a result, if a tool call starts while the transcript overlay is open and the user exits the overlay before the call finishes, the main view has no active cell showing that the tool is still running (and thus no way to monitor or cancel it) until the end event finally inserts a completed history cell. Consider either continuing to track those calls in an active cell or recreating one when transcript mode is disabled so running work remains visible in the normal UI.
Useful? React with 👍 / 👎.
We can now see tool calls in the transcript as they stream in.
Flushes active cell, but it's probably the simplest fix for this situation.