fix: preserve how response_error was set prior to #2103 #4925
+6
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am investigating #4381 and I believe this is the code that is the source of that error today:
codex/codex-rs/core/src/client.rs
Lines 652 to 662 in a43ae86
This code was touched recently as part of:
#2103
so this reverts some of the changes to
codex-rs/core/src/client.rs
introduced in that PR.While here, promote a number of events that were logging errors from
debug!()
toerror!()
.