reintroduce winget step to release job #7015
Open
+165
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bolinfest
approved these changes
Nov 20, 2025
Comment on lines
+590
to
+592
| version: ${{ needs.release.outputs.version }} | ||
| windows_x64_sha256: ${{ needs.release.outputs.windows_x64_sha256 }} | ||
| windows_arm64_sha256: ${{ needs.release.outputs.windows_arm64_sha256 }} |
Collaborator
There was a problem hiding this comment.
Is needs.release the right prefix?
| @@ -0,0 +1,36 @@ | |||
| WinGet manifests for the Codex CLI | |||
Collaborator
There was a problem hiding this comment.
I would not expect to find this here. I would make this the README.md for the .github/winget_templates folder. Or make this .github/workflows/winget.md.
Comment on lines
+411
to
+421
| if [[ -f "$x64_path" ]]; then | ||
| x64_sha=$(sha256sum "$x64_path" | awk '{print $1}') | ||
| else | ||
| echo "::warning::Windows x64 binary not found at $x64_path; winget validation will be skipped." | ||
| fi | ||
| if [[ -f "$arm_path" ]]; then | ||
| arm_sha=$(sha256sum "$arm_path" | awk '{print $1}') | ||
| else | ||
| echo "::warning::Windows arm64 binary not found at $arm_path; winget validation will be skipped." | ||
| fi |
Collaborator
There was a problem hiding this comment.
Is there any reasonable case in which these should fail? Should we just do this:
set -euo pipefail
x64_sha=$(sha256sum "$x64_path" | awk '{print $1}')
arm_sha=$(sha256sum "$arm_path" | awk '{print $1}')
why should we sweep errors under the rug?
|
|
||
| - name: Compute SHA256 for Windows EXEs | ||
| id: win_hash | ||
| continue-on-error: true |
Collaborator
There was a problem hiding this comment.
Assuming we make my suggested change below, I would drop this, as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the previous bug (the exe path was wrong when we were generating SHAs)
and also makes it so the main job won't fail if this part fails.