Add approval allow-prefix flow in core and tui #7037
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let policy = | ||
| crate::exec_policy::append_allow_prefix_rule_and_reload(&features, &codex_home, prefix) | ||
| .await?; |
There was a problem hiding this comment.
The new allow-prefix flow calls crate::exec_policy::append_allow_prefix_rule_and_reload when persisting approvals, but no such function exists in core/exec_policy. This call will not compile (unresolved function) and the allow-prefix approval path cannot run at all.
Useful? React with 👍 / 👎.
| let _ = codex | ||
| .submit(Op::ExecApproval { | ||
| id, | ||
| decision, | ||
| allow_prefix: None, |
There was a problem hiding this comment.
When the delegate handles an exec approval request that includes allow_prefix, it forwards the decision back to the parent with allow_prefix: None. Any user choice to persist the prefix in a delegated session is silently discarded, so the execpolicy allow list is never updated in this flow.
Useful? React with 👍 / 👎.
Stack created with Sapling. Best reviewed with ReviewStack.