refactor: inline sandbox type lookup in process_exec_tool_call #7122
+8
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I think this is duplicative with #7045 |
Collaborator
Author
|
@nornagon-openai perhaps? though I think this is a targeted and uncontroversial fix? |
nornagon-openai
approved these changes
Nov 21, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
process_exec_tool_call()was takingSandboxTypeas a param, but in practice, the only place it was constructed was incodex_message_processor.rswhere it was derived from the othersandbox_policyparam, so this PR inlines the logic that decides theSandboxTypeintoprocess_exec_tool_call().Stack created with Sapling. Best reviewed with ReviewStack.