-
Notifications
You must be signed in to change notification settings - Fork 7.2k
Use issuer URL in device auth prompt link #7858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use issuer URL in device auth prompt link #7858
Conversation
|
I have read the CLA Document and I hereby sign the CLA |
|
All contributors have signed the CLA ✍️ ✅ |
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@etraut-openai Happy New Year, Could you please review and merge this small change. Thank you! |
|
@abrar71, Happy New Year to you too. Yes, this is in the queue. The developer who is most familiar with this code was busy with other higher-priority work prior to the holiday break. We'll get to it soon. |
mzeng-openai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! This is very helpful, please make sure tests pass before you merge.
Summary
When using device-code login with a custom issuer (
--experimental_issuer), Codex correctly uses that issuer for the auth flow — but the terminal prompt still told users to open the default OpenAI device URL (https://auth.openai.com/codex/device). That’s confusing and can send users to the wrong domain (especially for enterprise/staging issuers). This PR updates the prompt (and related URLs) to consistently use the configured issuer. 🎯🔧 What changed
/)🧪 Repro + Before/After
❌ Before (wrong link shown)
✅ After (correct link shown)
Full example output (same as before, but with the correct URL):
✅ Test plan
🟦
codex login --device-auth(default issuer): output remains unchanged🟩
codex login --device-auth --experimental_issuer https://auth.example.com: