Skip to content

fix: brighten transcript copy affordance #8697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshka-oai merged 1 commit into from
Jan 3, 2026
Merged

fix: brighten transcript copy affordance #8697

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions codex-rs/tui2/src/transcript_copy_ui.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,8 +275,8 @@ impl TranscriptCopyUi {
};

let pill_area = Rect::new(x, y, pill_width, 1);
let base_style = Style::new().bg(Color::DarkGray);
let icon_style = base_style.fg(Color::Cyan);
let base_style = Style::new().bg(Color::DarkGray).fg(Color::White);
Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot Jan 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Avoid hardcoded white foreground in pill style

For terminals with custom ANSI palettes (common in light themes), forcing Color::White can yield poor contrast or outright illegible text against the configured DarkGray background, whereas using the theme’s default foreground preserves user-tuned readability. The TUI styling guidance in the repo explicitly warns against hardcoded white for this reason, so this change risks a regression for users who remap ANSI colors.

Useful? React with 👍 / 👎.

Copy link
Collaborator Author

@joshka-oai joshka-oai Jan 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is intentional for now - we can come back to tweak exact colors on this one (or make it so that this works similarly to the user prompt areas to darken / lighten the foreground colors.

let icon_style = base_style.add_modifier(Modifier::BOLD).fg(Color::LightCyan);
let bold_style = base_style.add_modifier(Modifier::BOLD);

let mut spans: Vec<Span<'static>> = vec![
Expand Down
Loading