tui2: copy selection dismisses highlight #8718
Merged
+319
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 28e30904c1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Clicking the transcript copy pill or pressing the copy shortcut
now copies the selected transcript text and clears the highlight.
Show transient footer feedback ("Copied"/"Copy failed") after a
copy attempt, with logic in transcript_copy_action to keep app.rs
smaller and closer to tui for long-term diffs.
Update footer snapshots and add tiny unit tests for feedback expiry.
joshka-oai
force-pushed
the
joshka/tui2-copy-dismiss-selection
branch
from
28e3090 to
5b9d2ac
Compare
The copy shortcut can be invoked before the first resize event or while the window is collapsed, when last_known_screen_size reports a width/height of 0. Restore the early-return guard before calling desired_height(width) so we never ask textwrap to wrap at width 0.
tibo-openai
approved these changes
Jan 5, 2026
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clicking the transcript copy pill or pressing the copy shortcut now copies the selected transcript text and clears the highlight.
Show transient footer feedback ("Copied"/"Copy failed") after a copy attempt, with logic in transcript_copy_action to keep app.rs smaller and closer to tui for long-term diffs.
Update footer snapshots and add tiny unit tests for feedback expiry.
Screen.Recording.2026-01-04.at.2.29.41.PM.mov