feat(tui2): transcript scrollbar (auto-hide + drag) #8728
Merged
+921
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshka-oai
force-pushed
the
joshka/tui2-scrollbar
branch
from
17cf7e6 to
db007d0
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 17cf7e6400
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
joshka-oai
force-pushed
the
joshka/tui2-scrollbar
branch
from
db007d0 to
036cc72
Compare
Collaborator
Author
Screen.Recording.2026-01-04.at.9.23.55.PM.mov |
Add tui-scrollbar to tui2 and introduce transcript_scrollbar. Render the scrollbar via a ratatui-core scratch buffer to bridge the pre-0.30 ratatui types.
Add a `tui-scrollbar`-based vertical scrollbar for the transcript viewport. - Reserve 2 columns (1 gap + 1 scrollbar) and plumb the reduced width through wrapping, selection/copy, and mouse handling so on-screen rendering matches interactions. - Only render the scrollbar when the view is scrolled away from the bottom (keep the reserved columns blank when pinned). - Style track/thumb using terminal fg/bg heuristics so it feels consistent with the user prompt block; in light themes the thumb is darker than the track.
Support click/drag on the transcript scrollbar track/thumb. Use tui-scrollbar's hit testing and drag interaction state, plus a small pointer-capture flag so dragging doesn't fall through into transcript selection when the view becomes pinned to bottom. Skip scrollbar hit-testing when the scrollbar is auto-hidden at bottom, so the reserved column is not an invisible interactive region. Move the interaction glue out of app.rs into transcript_scrollbar_ui. Return an explicit TranscriptScrollbarMouseHandling enum, and expand docs for reserved column layout and track/thumb theme heuristics.
joshka-oai
force-pushed
the
joshka/tui2-scrollbar
branch
from
036cc72 to
ef98c7b
Compare
tibo-openai
approved these changes
Jan 5, 2026
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
tui2usingtui-scrollbar.Notes
Testing
just fmtjust fix -p codex-tui2 --allow-no-vcscargo test -p codex-tui2