fix: do not propose to add multiline commands to execpolicy #8734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tibo-openai
changed the title
bolinfest
approved these changes
Jan 6, 2026
codex-rs/tui/src/exec_command.rs
Outdated
| let long = format!("python - <<'PY'\n{}\nPY\n", "x".repeat(500)); | ||
| let args = vec!["bash".into(), "-lc".into(), long]; | ||
| let label = render_for_approval_prefix_label(&args); | ||
| assert!(!label.contains('\n')); |
Collaborator
There was a problem hiding this comment.
Personally, I would just do the work to derive expected_label and then assert_eq!(expected_label, label) because then the failure of the assertion has a stronger signal and the difference should be pretty clear when the failure is printed.
That said, this is pretty low-risk, so you can also keep it as-is.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes inscrutable multiline approval requests by not proposing for them to be added to execpolicy. Example of prior failure (sent by a user):
