Skip to content

Conversation

@joshka-oai
Copy link
Collaborator

Display paths relative to the cwd before checking git roots so view image tool calls keep project-local names in jj/no-.git workspaces.

@joshka-oai joshka-oai requested a review from bolinfest January 6, 2026 01:01
Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3145779795

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@joshka-oai joshka-oai force-pushed the joshka/render-cwd-relative-paths branch from 3145779 to ea200d8 Compare January 6, 2026 01:06
@joshka-oai joshka-oai enabled auto-merge (squash) January 6, 2026 01:11
@joshka-oai joshka-oai force-pushed the joshka/render-cwd-relative-paths branch from ea200d8 to eda7666 Compare January 6, 2026 01:54
Prefer cwd-relative paths before checking git roots so view image tool
calls keep project-local names in jj/no-.git workspaces (avoid ~/...).

Document the helper and make the new test path handling cross-platform.
@joshka-oai joshka-oai force-pushed the joshka/render-cwd-relative-paths branch from eda7666 to 497e20c Compare January 6, 2026 01:56
@joshka-oai
Copy link
Collaborator Author

Flakey windows test...

@joshka-oai joshka-oai merged commit 4c3d2a5 into main Jan 6, 2026
45 of 47 checks passed
@joshka-oai joshka-oai deleted the joshka/render-cwd-relative-paths branch January 6, 2026 03:17
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants