suppress popups while browsing input history #8772
Conversation
xl-openai
changed the title
|
@codex review again |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fe605a2e96
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if browsing_history { | ||
| self.active_popup = ActivePopup::None; | ||
| return; |
There was a problem hiding this comment.
should_handle_navigation returns true for empty text whenever any history exists, so this early return runs even after the user clears the composer (not just while actively pressing Up/Down). That bypasses the later dismissed_*_popup_token = None resets, meaning a popup dismissed with Esc can stay suppressed forever for the same query: clear input → type the same @.../$... again → popup never reopens because the dismissal was never cleared. Consider clearing dismissed tokens before returning, or keying the guard off an active history cursor instead of empty text.
Useful? React with 👍 / 👎.
No description provided.