Elevated sandbox NUX #8789

iceweasel-oai · 2026-01-06T19:05:58Z

Elevated Sandbox NUX:

prompt for elevated sandbox setup when agent mode is selected (via /approvals or at startup)
prompt for degraded sandbox if elevated setup is declined or fails
introduce /elevate-sandbox command to upgrade from degraded experience.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1e74fe4221

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/core/src/lib.rs

codex-rs/tui/src/app.rs

codex-rs/tui2/src/app.rs

codex-rs/tui/src/bottom_pane/list_selection_view.rs

iceweasel-oai · 2026-01-07T18:13:02Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 73dd5638db

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/bottom_pane/chat_composer.rs

codex-rs/core/src/config/mod.rs

dylan-hurd-oai · 2026-01-07T18:55:58Z

codex-rs/core/src/windows_sandbox.rs

+
+#[cfg(not(target_os = "windows"))]
+pub fn sandbox_setup_is_complete(_codex_home: &Path) -> bool {
+    false


Should this return true? There is no need to do windows sandbox setup on other platforms, so it is compete in a technical/literal sense. Less technically speaking, if a check on this condition leaks into linux/macos code, we probably don't want to follow the path more likely to to invoke run_elevated_setup

yeah I'll update this in a future PR. For now there is no leakage

dylan-hurd-oai · 2026-01-07T18:59:08Z

codex-rs/tui/src/bottom_pane/chat_composer.rs

+    cfg!(target_os = "windows")
+        && codex_core::windows_sandbox::ELEVATED_SANDBOX_NUX_ENABLED
+        && codex_core::get_platform_sandbox().is_some()
+        && !codex_core::is_windows_elevated_sandbox_enabled()


This feels like we're piling tech debt on top of the "2 booleans" problem

agreed, will address in a future PR

dylan-hurd-oai · 2026-01-07T18:59:31Z

codex-rs/tui/src/bottom_pane/chat_composer.rs

 use std::time::Duration;
 use std::time::Instant;

+fn windows_degraded_sandbox_active() -> bool {


Can we s/degraded/partial/g ?

codex-rs/tui/src/bottom_pane/chat_composer.rs

dylan-hurd-oai · 2026-01-07T19:21:34Z

codex-rs/tui/src/chatwidget.rs

                #[cfg(not(target_os = "windows"))]
                {
                    Self::approval_preset_actions(preset.approval, preset.sandbox.clone())
                }


nit: can we bump the non-windows variant to be first here?

dylan-hurd-oai · 2026-01-07T19:23:08Z

codex-rs/tui/src/chatwidget.rs

+                                    preset: preset_clone.clone(),
+                                });
+                            })]
+                        }


[non-blocking] I know this PR is not the source of the problem, but I feel like we're reaching a tipping point with the complexity in this function - we're iterating over the presets as if we're agnostic, but almost all of the logic in the function is targeted at specific variants. Seems like we'd be better off with a more declarative pattern.

dylan-hurd-oai · 2026-01-07T19:24:07Z

codex-rs/tui/src/chatwidget.rs

    }

    #[cfg(target_os = "windows")]
    pub(crate) fn open_windows_sandbox_enable_prompt(&mut self, preset: ApprovalPreset) {


could we move this function out of chatwidget into its own module?

will do in a future PR

dylan-hurd-oai · 2026-01-07T19:24:47Z

codex-rs/tui/src/chatwidget.rs

    pub(crate) fn open_windows_sandbox_enable_prompt(&mut self, _preset: ApprovalPreset) {}

+    #[cfg(target_os = "windows")]
+    pub(crate) fn open_windows_sandbox_fallback_prompt(


ditto above, separate module for this code would be really helpful

will do in a future PR

dylan-hurd-oai · 2026-01-07T19:25:50Z

codex-rs/tui2/src/app.rs

+                self.chat_widget
+                    .open_windows_sandbox_fallback_prompt(preset, reason);
+            }
+            AppEvent::BeginWindowsSandboxElevatedSetup { preset } => {


can we wrap this handler logic into a function similar to open_windows_sandbox_fallback_prompt?

will do in a future PR

dylan-hurd-oai · 2026-01-08T23:16:04Z

@codex review again please!

chatgpt-codex-connector · 2026-01-08T23:28:24Z

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector bot reviewed Jan 6, 2026

View reviewed changes

codex-rs/core/src/lib.rs Show resolved Hide resolved

codex-rs/tui/src/app.rs Outdated Show resolved Hide resolved

codex-rs/tui2/src/app.rs Outdated Show resolved Hide resolved

iceweasel-oai commented Jan 6, 2026

View reviewed changes

codex-rs/tui/src/bottom_pane/list_selection_view.rs Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Jan 7, 2026

View reviewed changes

codex-rs/tui/src/bottom_pane/chat_composer.rs Show resolved Hide resolved

dylan-hurd-oai reviewed Jan 7, 2026

View reviewed changes

iceweasel-oai force-pushed the dev/iceweasel/elevated-sandbox-nux branch from 73dd563 to 98aa544 Compare January 8, 2026 05:59

iceweasel-oai requested a review from dylan-hurd-oai January 8, 2026 06:24

iceweasel-oai added 14 commits January 8, 2026 11:26

Elevated sandbox NUX

d264321

fix unused var

4276c6e

snapshots

e5a52ab

fix build issues, forgot to add a file.

e484710

fix non-Windows build errors

0def6e5

fix lint error

994033a

build errors

20906ff

cargo fmt

46ab959

include a kill switch to revert to previous NUX

234b0df

copy/functionality update

c9516e9

Sync footer note and input enabled plumbing

c55e041

merge conflicts

9291dfe

run tests that change global vars serially

73e018b

fmt and clippy fix

4111eae

iceweasel-oai force-pushed the dev/iceweasel/elevated-sandbox-nux branch from c8e5101 to 4111eae Compare January 8, 2026 19:28

iceweasel-oai added 4 commits January 8, 2026 13:30

re-introduce lost code in merge

000b90d

unused import

b7fb220

update snapshots with new label

5483198

fix snapshots for real

a2e9a3e

dylan-hurd-oai approved these changes Jan 9, 2026

View reviewed changes

iceweasel-oai merged commit 6372ba9 into main Jan 9, 2026
26 checks passed

iceweasel-oai deleted the dev/iceweasel/elevated-sandbox-nux branch January 9, 2026 00:23

github-actions bot locked and limited conversation to collaborators Jan 9, 2026

Elevated sandbox NUX #8789

Elevated sandbox NUX #8789

Uh oh!

Conversation

iceweasel-oai commented Jan 6, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

iceweasel-oai commented Jan 7, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dylan-hurd-oai commented Jan 8, 2026

Uh oh!

chatgpt-codex-connector bot commented Jan 8, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants