Use markdown for migration screen #8952
Conversation
|
@codex fix lint |
aibrahim-oai
force-pushed
the
migration-markdown
branch
from
f24a91e to
878cc4d
Compare
|
Summary
Testing
|
|
@codex fix ci and tests |
|
Summary
Testing
|
…into migration-markdown
|
@codex review this |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9f196ea521
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| r#"**Codex just got an upgrade. Introducing {model_to}.** | ||
| Codex is now powered by gpt-5.2-codex, our latest frontier agentic coding model. It is smarter and faster than its predecessors and capable of long-running project-scale work. | ||
| Learn more about {model_to} at https://openai.com/index/introducing-gpt-5-2-codex |
There was a problem hiding this comment.
The expected migration_markdown in gpt52_codex_upgrade() includes a blank line before “Learn more…”, but the real preset in core/src/models_manager/model_presets.rs keeps “Learn more…” in the same paragraph. Because list_models_returns_* uses assert_eq! on full ModelPreset values, this mismatch makes those tests fail whenever they run. Either update this expected string to exactly match the preset or adjust the preset to match the new paragraphing so the comparison stays stable.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Summary
- Aligned the gpt-5.2-codex migration markdown test fixture with the preset’s paragraphing to match expected output. codex-rs/core/tests/suite/list_models.rsL403-L420
Testing
- ✅
just fmt - ✅
just fix -p codex-core - ❌
cargo test -p codex-core(failed:exec::tests::kill_child_process_group_kills_grandchildren_on_timeoutreports a grandchild process still alive) - ❌
cargo test -p codex-core exec::tests::kill_child_process_group_kills_grandchildren_on_timeout -- --nocapture(failed: grandchild process still alive) ⚠️ cargo test --all-features(not run; requires approval)
Next steps will be routing this to model info