Conversation naming #8991
Conversation naming #8991
Conversation
JaviSoto
left a comment
JaviSoto
left a comment
There was a problem hiding this comment.
Looks good!!
Random suggestion I just thought of: it could be useful to give the agent a way to set the name as well via a tool call, so you can tell the agent to name the conversation as well? (you could even add something to your AGENTS.md with instructions on how you want the agent to name your sessions, or to rename them in certain cases etc)
codex-rs/cli/src/main.rs
Outdated
| #[derive(Debug, Parser)] | ||
| struct ResumeCommand { | ||
| /// Conversation/session id (UUID). When provided, resumes this session. | ||
| /// Conversation/session id (UUID) or session name. UUIDs take precedence if it parses. |
| pub struct SessionMetaUpdatedEvent { | ||
| /// Name left as session_id instead of thread_id for backwards compatibility. | ||
| pub session_id: ThreadId, | ||
| #[serde(default, skip_serializing_if = "Option::is_none")] |
jif-oai
left a comment
jif-oai
left a comment
There was a problem hiding this comment.
I would def go to the index file
- can we try to use
threadinstead ofsessionas much as possible
| Ok(()) | ||
| } | ||
|
|
||
| async fn rewrite_session_name( |
There was a problem hiding this comment.
Those functions should not be needed. We should use the same mechanism as for the model used during the rollout for example
|
@jif-oai @JaviSoto moved to an index file instead of SessionMeta so we don't touch rollout files. We're reading a Implemented your comments (adding tests on resume, move to thread, thread_name or thread_id naming) |
Session renaming:
/rename my_session/renamewithout arg and passing an argument incustomViewPromptCODEX_HOME/sessions.jsonlSession resuming:
CODEX_HOME/sessions.jsonlfirst entry matching the name and resumes the session