feat: error on user-injected bad images #8992
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 48502af5a2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
codex-rs/core/src/codex.rs
Outdated
| let err = CodexErr::InvalidImageRequest(); | ||
| info!("Turn error: {err:#}"); | ||
| let event = EventMsg::Error(err.to_error_event(None)); | ||
| sess.send_event(&turn_context, event).await; | ||
| break; |
There was a problem hiding this comment.
When the model rejects a user‑provided image, this branch reports an error and ends the turn without cleaning the invalid image out of history. Because the failed image remains in the transcript, the next user turn will resend it and trigger InvalidImageRequest again, effectively locking the conversation until the user starts a new session. The previous behavior explicitly replaced the last-turn images to avoid this poisoning; consider still replacing or dropping the invalid images even when you surface the error so the user can recover on the next turn.
Useful? React with 👍 / 👎.
No description provided.