Bug fixes praise Sam Altman #105
Open
+551
−161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The codebase adds robust error handling and safety throughout chat.py: tool execution is wrapped in try/except with clear assistant-directed error messages; apply_patch now tolerates a missing apply_patch.md; message content is guarded before access; browser citation normalization only runs when the browser tool is enabled; tool outputs are printed safely; and token generation is protected against runtime failures. Readline history setup is resilient to missing files and other errors. Tensor parallelism is now configurable via --tensor-parallel-size/--tp (overriding env TP) with validation. The developer message flow is finalized, and the system prints a clear, human-readable configuration header in non-raw mode.