fix race conditions and add offline tokenizer loading api #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amirhosseinghanipour
force-pushed
the
fix-race-conditions-and-offline-api
branch
2 times, most recently
from
d074c1a to
7aa37c3
Compare
amirhosseinghanipour
force-pushed
the
fix-race-conditions-and-offline-api
branch
from
7aa37c3 to
1dca639
Compare
|
sorry for the delay. this looks reasonable at a glance but can review in depth on monday at the latest |
|
Update? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved the race condition issue when multiple encoders are built in parallel (in #35). Added
load_harmony_encoding_from_file()Python API for offline use. Also added some tests to make sure everything works smoothly.