Skip to content

fix Twilio handoff audio format #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 10, 2025
Merged

fix Twilio handoff audio format #126

merged 3 commits into from
Jul 10, 2025

Conversation

@dkundel-openai
Copy link
Collaborator

@dkundel-openai dkundel-openai commented Jun 19, 2025

Summary

  • keep g711 format when updating Twilio sessions
  • test that updateSessionConfig preserves Twilio audio settings

Testing

  • pnpm build
  • pnpm test
  • pnpm lint

https://chatgpt.com/codex/tasks/task_i_685375c694108331bd25bad0e004f0d2

@changeset-bot
Copy link

changeset-bot bot commented Jun 19, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 408e4cb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dkundel-openai
Copy link
Collaborator Author

dkundel-openai commented Jun 19, 2025

Have to verify this fix still.

@seratch seratch marked this pull request as draft June 19, 2025 22:41
@github-actions
Copy link
Contributor

github-actions bot commented Jun 30, 2025

This PR is stale because it has been open for 10 days with no activity.

@github-actions github-actions bot added stale and removed stale labels Jun 30, 2025
@kkarkos kkarkos mentioned this pull request Jul 8, 2025
Open
@dkundel-openai dkundel-openai marked this pull request as ready for review July 9, 2025 00:31
seratch
seratch approved these changes Jul 10, 2025
View reviewed changes
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will merge this later

@seratch seratch merged commit abf10c2 into main Jul 10, 2025
5 checks passed
@seratch seratch deleted the codex/fix-broken-audio-after-agent-handoff-in-twilio branch July 10, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seratch seratch seratch approved these changes

Assignees

No one assigned

Labels

codex package:agents-extensions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dkundel-openai @seratch