-
Notifications
You must be signed in to change notification settings - Fork 501
fix: make zod a peerDependency to dedupe installed versions #274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
7cffa9e to
aa11304
Compare
|
@seratch tagging you for review |
|
@ianduvall Thanks for sending this PR! I don't have the bandwidth to carefully check this issue right now, but will start working on this soon. |
|
@ianduvall you should be changing the relevant readme files as well? |
|
@ianduvall this seems to have some conflicts now how would this be used? would that allow different submodules to still use higher versions if they specify as a peer-dep? |
aa11304 to
08afd8f
Compare
Yep
You would need to stay within the supported version range. A follow up to this PR would be to add support for Zod v4. |
I'll leave that for the end to avoid conflicts |
08afd8f to
87e64b9
Compare
|
@ianduvall Thanks for working on this. I found that this PR needs an additional commit, so I come up with #342 including your contributions. |
Summary
Moves
zodto be a peer dependency as suggested by the zod maintainerTest plan
TBD
Issue number
Closes #187
Checks
pnpm testandpnpm test:examplespnpm test:integration(see details)pnpm changesetto indicate my changes