Skip to content

Conversation

@seratch
Copy link
Member

@seratch seratch commented Sep 9, 2025

This pull request aligns with openai/openai-agents-python#1689.

Additional changes

  • ensure final outputs emitted in the same turn are delivered once synchronous tool execution finishes so structured agents do not loop forever.
  • update executeToolsAndSideEffects tests so they assert the new final-output behavior for text and structured agents once synchronous tool execution finishes in the same turn.

https://chatgpt.com/codex/tasks/task_i_68bfdbf8e64c83208fe2a8fb32224e10

@changeset-bot
Copy link

changeset-bot bot commented Sep 9, 2025

⚠️ No Changeset found

Latest commit: dac88cd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@seratch seratch merged commit 0bb13c1 into codex/fix-comments-in-runimplementation.ts Sep 9, 2025
5 checks passed
@seratch seratch deleted the codex/fix-test-failures branch September 9, 2025 08:01
seratch added a commit that referenced this pull request Sep 9, 2025
* fix(agents-core): finalize output after tool run
* test(agents-core): update execution expectations (#453)
@seratch seratch changed the title fix: delay final output until tools complete PR for #451 - fix: delay final output until tools complete Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant