Skip to content

Conversation

@rm-openai
Copy link
Collaborator

@rm-openai rm-openai commented Jul 14, 2025

The model listens to websocket events in a separate task, and the session receives those events in on_event. So if there's e.g. a websocket or json exception, it's silently dropped. Similar to the streaming text agents, we should:

  • capture exceptions separately
  • raise them in async for event in session loop.

Added tests to verify.


@rm-openai rm-openai requested a review from seratch July 14, 2025 17:42
rm-openai added a commit that referenced this pull request Jul 14, 2025
Guardrails were blocking the event loop. Now, they run as a separate
task.




---
[//]: # (BEGIN SAPLING FOOTER)
* #1112
* #1111
* #1107
* #1106
* __->__ #1104
rm-openai added a commit that referenced this pull request Jul 14, 2025
cleanup





---
[//]: # (BEGIN SAPLING FOOTER)
* #1112
* #1111
* #1107
* __->__ #1106
Base automatically changed from rm/pr1106 to main July 14, 2025 21:35
@rm-openai rm-openai merged commit af4cef3 into main Jul 14, 2025
15 checks passed
@rm-openai rm-openai deleted the rm/pr1107 branch July 14, 2025 21:53
@seratch seratch added enhancement New feature or request feature:realtime labels Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request feature:realtime

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants