fix(translate_docs): use chat.completions.create instead of responses.create #1132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….create Update the `translate_file` to call the correct OpenAI Python SDK method for generating chat completions. Both instances of the non‑existent `openai_client.responses.create` have been replaced with `openai_client.chat.completions.create`, restoring compatibility with the current SDK and preventing runtime attribute errors.
….create Update the translate_file to call the correct OpenAI Python SDK method for generating chat completions. Both instances of the non‑existent openai_client.responses.create have been replaced with openai_client.chat.completions.create, restoring compatibility with the current SDK and preventing runtime attribute errors.
…t.completions
**What Changed**
- Replaced all calls to
```python
openai_client.chat.completions.create(
model=OPENAI_MODEL,
instructions=instructions,
input=chunk,
# …
)
```
with
```python
openai_client.chat.completions.create(
model=OPENAI_MODEL,
messages=[
{"role": "system", "content": instructions},
{"role": "user", "content": chunk},
],
# optional temperature override
)
```
* Unified the “o\*” vs. non‑“o\*” branches into a single code path, conditionally adding `temperature=0.0` for non‑o models.
* Switched result extraction from `response.output_text` to `response.choices[0].message.content`.
**Why This Matters**
* Eliminates the type‑checking errors raised by mypy.
* Aligns the code with the current OpenAI chat completion API, improving future compatibility and clarity.
* Simplifies the logic by removing duplicated branches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the
translate_fileto call the correct OpenAI Python SDK method for generating chat completions.Both instances of the non‑existent
openai_client.responses.createhave been replaced withopenai_client.chat.completions.create, restoring compatibility with the current SDK and preventing runtime attribute errors.