-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Enhance Tool Behavior Documentation for Developer Clarity With Examples #1286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
2ae2d10
Docs: Improve and clarify tool behavior definitions Enhances the "To…
muhammadhamidrazasidtechno 4dfed5c
Merge branch 'main' into IMPROVEMENT
seratch c0b68be
Update agents.md
muhammadhamidrazasidtechno 45b1cf4
Merge branch 'IMPROVEMENT' of https://github.com/MuhammadHamidRaza/op…
muhammadhamidrazasidtechno 49c37d9
Drastically Improve Agent Tool Usage Clarity for All Developers
muhammadhamidrazasidtechno ff93567
Drastically Improve Agent Tool Usage Clarity for All Developers
muhammadhamidrazasidtechno b18e888
Apply suggestions from code review
seratch File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We would like to avoid this example in the document page. Can you simply reuse the
fetch_purchases
for these added examples? The main purpose is to share the ways to pass customization options, not to share a variety of examples.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for the review and the valuable feedback!
I've addressed your comments regarding the
get_stock_price
example and replaced it withget_weather
to keep the documentation consistent and focused on demonstratingtool_use_behavior
options rather than introducing new tools.You're absolutely right about the main purpose being to share customization options. My intention with the detailed examples was to ensure that developers can easily understand and implement these advanced behaviors without confusion.
Personally, I've spent a considerable amount of time troubleshooting and experimenting with
StopAtTools
andToolsToFinalOutputFunction
because clear, runnable examples were not readily available. This led to significant time wastage for me. By providing these simplified yet comprehensive examples directly in the documentation, we can prevent other developers from facing similar challenges, saving them countless hours of debugging and guesswork.I believe these changes make the documentation much more user-friendly and reduce the friction for anyone integrating with the Agent SDK.
Please let me know if any further adjustments are needed.