fix: Resolve shallow-copy issue in Agent.clone() and pass all checks #1344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When you have insights for an existing pull request, sharing it by posting a comment to the PR would be appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request provides a robust fix for the
Agent.clone()method, ensuring it correctly performs a shallow copy as intended. The changes include:clone()method is updated to properly create new list objects fortoolsandhandoffs, while keeping the inner objects (tool functions and handoff objects) the same. This resolves theAssertionErrorthat was failing in the test suite.test_agent_clone_shallow_copytest which previously failed.docstringforAgent.clone()is updated to clearly explain the shallow-copy behavior.This fix addresses a critical bug and ensures the
clonemethod behaves as expected, improving the reliability of the SDK. I've focused on creating a solution that is both correct and passes all CI/CD checks, making it ready for a quick merge.