Align make check with CI pipeline #1348
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that
make checkfails locally due to formatting issues (ruff format --check), but CI passes just fine. Looks like the CI only runs lint/type/tests, but doesn’t actually check code formatting.This PR syncs up the local
make checkcommand with the checks we run in CI.format-checkto CI: The CI will now fail if code isn't formatted correctly, which prevents surprises when pullingmain.make check: Updates thecheckcommand to runcoverageinstead of justtests, so it matches the CI test step exactly.Now, if it passes locally, it should pass in CI.