Skip to content

fix(handoff): enforce strict boolean return in _check_handoff_enabled #1377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix(handoff): enforce strict boolean return in _check_handoff_enabled #1377

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51a7a43
fix(handoff): enforce strict boolean return in _check_handoff_enabled
mshsheikh Aug 5, 2025
62d42e6
Merge branch 'main' into patch-31
mshsheikh Aug 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/agents/realtime/session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -594,8 +594,8 @@ async def _check_handoff_enabled(handoff_obj: Handoff[Any, RealtimeAgent[Any]])
return attr
res = attr(context_wrapper, agent)
if inspect.isawaitable(res):
return await res
return res
res = await res
return bool(res)

results = await asyncio.gather(*(_check_handoff_enabled(h) for h in handoffs))
enabled = [h for h, ok in zip(handoffs, results) if ok]
Expand Down