Skip to content

Updated the default values for two parameters in the ModelSettings class to align with their documented behavior: #1392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 11, 2025
Merged

Updated the default values for two parameters in the ModelSettings class to align with their documented behavior: #1392

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
adf2146
Updated the default values for two parameters in the ModelSettings cl…
rudra-attri Aug 7, 2025
7c22ce1
Merge branch 'main' into fix/model-settings
rudra-attri Aug 8, 2025
0851ed1
Merge branch 'main' into fix/model-settings
rudra-attri Aug 11, 2025
e6a6398
fix: revert incorrect default values and update documentation
rudra-attri Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/agents/model_settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,11 +104,11 @@ class ModelSettings:
metadata: dict[str, str] | None = None
"""Metadata to include with the model response call."""

store: bool | None = None
store: bool | None = True
"""Whether to store the generated model response for later retrieval.
Defaults to True if not provided."""

include_usage: bool | None = None
include_usage: bool | None = True
"""Whether to include usage chunk.
Defaults to True if not provided."""

Expand Down