fix(agent): stricter validation for Agent.prompt type checking #1571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…attr(get) fix(agent): validate Agent.prompt against Prompt class instead of hasattr(get)
|
Your code's Python indentation looks broken. But more importantly, Prompt class is TypedDict, so I don't think simply checking this way can work out well. Thanks for your interest and sending this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the validation logic for the Agent.prompt field in agent.py.
🔧 Changes
⚫ Replaced hasattr(self.prompt, "get") check with a strict isinstance(self.prompt, Prompt) check.
⚫ Ensures only valid Prompt objects or DynamicPromptFunction (callable) are accepted.
⚫ Prevents invalid objects (e.g., dict with .get() method) from being mistakenly allowed.
✅ Why this matters
⚫ Increases type safety and prevents runtime errors when an invalid prompt object is passed.
⚫ Makes the behavior more predictable and aligned with the intended usage (Prompt | DynamicPromptFunction | None).