Reorder hooks into chronological lifecycle order #1677
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary This PR defines correct lifecycle order of hooks for both `RunHooksBase` and `AgentHooksBase`, aligning with the logical execution flow of an agent run. ## Changes Made I have simply **reordered the hooks** to reflect their chronological execution sequence during an agent run. ### RunHooksBase ``` on_agent_start on_llm_start on_llm_end on_tool_start on_tool_end on_handoff on_agent_end ``` ### AgentHooksBase ``` on_start on_llm_start on_llm_end on_tool_start on_tool_end on_handoff on_end ``` ## Enhancement - Establishes a clear and **logical sequence** for hook execution. - Improves developer understanding by reflecting the **actual lifecycle**: - **Start → LLM Call → Tool Call → Handoff (if any) → End** This ordering provides consistency and clarity to understand the correct agent execution flow.
|
Thanks for the suggestion. To me, either is fine but if you resolve the CI errors, we may merge this. |
Resolved all CI linting errors in lifecycle.py to comply with project style guidelines and unblock the failing lint check in CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR defines correct lifecycle order of hooks for both
RunHooksBaseandAgentHooksBase, aligning with the logical execution flow of an agent run.Changes Made
I have simply reordered the hooks to reflect their chronological execution sequence during an agent run.
RunHooksBase
AgentHooksBase
Enhancement
This ordering provides consistency and clarity to understand the correct agent execution flow.