Fix session history duplication after PR #1550 #1700
Merged
+4
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1699, and fixes session history duplication introduced in #1550.
Problem:
When using sessions, the second
Runner.run()
call was saving combined input (history + new user input) instead of just the new user input, causing session history to be re-saved and duplicated.Root cause:
Line 442 was saving
original_input
which contained the combined session history, not the actual user input.Fix:
Separate
original_user_input
fromprepared_input
(which includes session history). Save only the new user input to prevent duplication.Verification: Session items go from 6 → 4 in the same repro script as the original issue (2 turns × 2 items each, no duplicates).