Fix/consistent generic type handling #1714
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Preserve Generic Type Information in ToolContext
Problem
There was an inconsistency in how
RunContextWrapper[T]generics were handled between dynamic instructions and tool validation functions:ctx.context.ageworked correctly ✅ctx.context.agethrewAttributeError: 'dict' object has no attribute 'age'❌This forced developers to manually convert context using
UserDataType.model_validate(ctx.context)in tool validation functions.Root Cause
The issue was in
ToolContext.from_agent_context()method which used field-by-field copying: