Skip to content

Fixed Race Condition in RunResultStreaming.stream_events() Method #1745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 16, 2025
+30 −23
Merged

Fixed Race Condition in RunResultStreaming.stream_events() Method #1745

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9aeb460
fix: resolve race condition in RunResultStreaming.stream_events() cau…
AnkanMisra Sep 15, 2025
c95cbd7
feat:fixed the lint error
AnkanMisra Sep 15, 2025
b261abb
fix: add cleanup guarantee to stream_events
AnkanMisra Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/agents/result.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,10 @@ async def stream_events(self) -> AsyncIterator[StreamEvent]:
yield item
self._event_queue.task_done()

# Ensure main execution completes before cleanup to avoid race conditions
# with session operations
await self._await_task_safely(self._run_impl_task)
# Safely terminate all background tasks after main execution has finished
self._cleanup_tasks()

if self._stored_exception:
Expand Down