-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Add default include of reasoning.encrypted_content for store=False to prevent reasoning errors #1756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
ihower
wants to merge
1
commit into
openai:main
from
ihower:fix-store-false-default-include-reasoning
Closed
Add default include of reasoning.encrypted_content for store=False to prevent reasoning errors #1756
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
import pytest | ||
from openai.types.responses.response_usage import InputTokensDetails, OutputTokensDetails | ||
|
||
from agents import ModelSettings, ModelTracing, OpenAIResponsesModel | ||
|
||
|
||
class DummyResponses: | ||
async def create(self, **kwargs): | ||
self.kwargs = kwargs | ||
|
||
class DummyResponse: | ||
id = "dummy" | ||
output = [] | ||
usage = type( | ||
"Usage", | ||
(), | ||
{ | ||
"input_tokens": 0, | ||
"output_tokens": 0, | ||
"total_tokens": 0, | ||
"input_tokens_details": InputTokensDetails(cached_tokens=0), | ||
"output_tokens_details": OutputTokensDetails(reasoning_tokens=0), | ||
}, | ||
)() | ||
|
||
return DummyResponse() | ||
|
||
|
||
class DummyClient: | ||
def __init__(self): | ||
self.responses = DummyResponses() | ||
|
||
|
||
@pytest.mark.allow_call_model_methods | ||
@pytest.mark.asyncio | ||
async def test_store_false_includes_encrypted_reasoning(): | ||
client = DummyClient() | ||
model = OpenAIResponsesModel(model="gpt-5", openai_client=client) # type: ignore | ||
await model.get_response( | ||
system_instructions=None, | ||
input="hi", | ||
model_settings=ModelSettings(store=False), | ||
tools=[], | ||
output_schema=None, | ||
handoffs=[], | ||
tracing=ModelTracing.DISABLED, | ||
previous_response_id=None, | ||
) | ||
include = set(client.responses.kwargs["include"]) | ||
assert "reasoning.encrypted_content" in include |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
non-reasoning models such as gpt-4.1 do not require this (actually it does not work), so always having this does not work. why don't you manually add this option to include?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, I forgot to consider that GPT-4.1 would throw errors, and this solution will cause breaking changes, which is not good. However, I do hope there’s a better way to help developers realize that when Store=False, they need to include reasoning.encrypted_content, otherwise GitHub issues will keep showing up.