Skip to content

Fix: Exclude unset fields in OpenAIConversationsSession.get_items() #1883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 14, 2025
Merged

Fix: Exclude unset fields in OpenAIConversationsSession.get_items() #1883

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e48735
fix: exclude unset fields in OpenAIConversationsSession.get_items()
ihower Oct 11, 2025
a8a090f
Merge branch 'main' into fix-openai-conversation-session
seratch Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/agents/memory/openai_conversations_session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,15 +50,15 @@ async def get_items(self, limit: int | None = None) -> list[TResponseInputItem]:
order="asc",
):
# calling model_dump() to make this serializable
all_items.append(item.model_dump())
all_items.append(item.model_dump(exclude_unset=True))
Comment on lines 52 to +53
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot Oct 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge status=None still serialized from conversation items

Switching to item.model_dump(exclude_unset=True) does not remove keys whose values are explicitly None. GPT‑5 reasoning items returned from the Conversations API include status set to null, so this call still emits {"status": None} and the Responses API continues to reject input[1].status. To avoid the error the code needs to exclude None values (e.g. exclude_none=True, optionally combined with exclude_unset). As written, the bug described in the commit message remains reproducible for second‑turn requests.

Useful? React with 👍 / 👎.

Copy link
Contributor Author

@ihower ihower Oct 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The status=None field comes from the ResponseReasoningItem model, it has a default value of None. So when we call model_dump(exclude_unset=True), it does remove this field as expected.

else:
async for item in self._openai_client.conversations.items.list(
conversation_id=session_id,
limit=limit,
order="desc",
):
# calling model_dump() to make this serializable
all_items.append(item.model_dump())
all_items.append(item.model_dump(exclude_unset=True))
if limit is not None and len(all_items) >= limit:
break
all_items.reverse()
Expand Down