Add new tools for gpt-5.1 #2079
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| def _coerce_shell_call(tool_call: Any) -> ShellCallData: | ||
| call_id = _extract_shell_call_id(tool_call) | ||
| action_payload = _get_mapping_or_attr(tool_call, "action") | ||
| if action_payload is None: | ||
| raise ModelBehaviorError("Shell call is missing an action payload.") | ||
|
|
||
| commands_value = _get_mapping_or_attr(action_payload, "commands") | ||
| if not isinstance(commands_value, Sequence): | ||
| raise ModelBehaviorError("Shell call action is missing commands.") | ||
| commands: list[str] = [] | ||
| for entry in commands_value: | ||
| if entry is None: | ||
| continue |
There was a problem hiding this comment.
When a ShellTool is registered, _process_response now routes both the new shell_call items and the legacy LocalShellCall items through ShellAction. However, _coerce_shell_call only looks for an action.commands sequence. LocalShellCallAction produced by today’s models exposes the field as command, so commands_value is always None and this code raises ModelBehaviorError("Shell call action is missing commands."). That means any agent that enables the new shell tool immediately crashes as soon as a legacy local_shell_call is emitted (the current behavior for GPT‑4/5), making the feature unusable. The parser must accept both command and commands (and coerce a single list into the new structure) to keep backward compatibility.
Useful? React with 👍 / 👎.
No description provided.