-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Add options for customizing the way to establish a connection via websockets library #2264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
aligokalppeker
wants to merge
11
commits into
openai:main
Choose a base branch
from
aligokalppeker:feature/realtime_connection_features
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+608
−5
Draft
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
d713fdd
Convert tool execution exception to runtime error, fixes #2204
aligokalppeker e3d08bf
Merge branch 'main' into bugfix/wrong_toolname_failure
aligokalppeker 4c4bb24
Implement websocket connection configuration
aligokalppeker 4dbe176
Eliminate sock factory, it is not required.
aligokalppeker 717225d
Remove unused import
aligokalppeker ef0c19f
Fix unit tests.
aligokalppeker 9ab3f93
Merge branch 'main' into feature/realtime_connection_features
aligokalppeker 26d39e9
Remove unused imports.
aligokalppeker dbbcd4d
Merge branch 'main' into feature/realtime_connection_features
aligokalppeker af06277
Added unit tests for the new configurations.
aligokalppeker c4cb13e
Test suite for the TransportConfig
aligokalppeker File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these properties are websockets library specific, so I am thinking of a better naming. I am focusing on other stuff (especially making the HITL successful) so let me hold off deciding details here for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood, waiting for it. One note, these are fairly common concepts that also exist in other WebSocket libraries, as keeping alive through pings is a WebSocket standard.