Skip to content

Conversation

rm-openai
Copy link
Collaborator

Towards #345

Summary:

Using a dict or Mapping isn't strict-mode compliant. But we were checking for the literal True whereas the value can also be an array, for example. Fix that.

Test Plan:

Unit tests

@rm-openai rm-openai requested a review from stevenheidel March 26, 2025 19:10
Towards #345

## Summary:
Using a `dict` or `Mapping` isn't strict-mode compliant. But we were checking for the literal `True` whereas the value can also be an array, for example. Fix that.

## Test Plan:

Unit tests
@rm-openai rm-openai merged commit 4854a74 into main Mar 26, 2025
10 checks passed
@rm-openai rm-openai deleted the rm/pr356 branch March 26, 2025 19:52
johnandersen777 pushed a commit to johnandersen777/openai-agents-python that referenced this pull request Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants