Skip to content

fix: count spans and traces correctly #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 12, 2025
Merged

fix: count spans and traces correctly #55

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d49bd89
count both spans and traces
dot-agi Mar 12, 2025
6962410
Revert "count both spans and traces"
dot-agi Mar 12, 2025
e591772
resort to show total number of spans and traces
dot-agi Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/agents/tracing/processors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,6 @@ def export(self, items: list[Trace | Span[Any]]) -> None:
logger.warning("OPENAI_API_KEY is not set, skipping trace export")
return

traces: list[dict[str, Any]] = []
spans: list[dict[str, Any]] = []

data = [item.export() for item in items if item.export()]
payload = {"data": data}

Expand All @@ -100,7 +97,7 @@ def export(self, items: list[Trace | Span[Any]]) -> None:

# If the response is successful, break out of the loop
if response.status_code < 300:
logger.debug(f"Exported {len(traces)} traces, {len(spans)} spans")
logger.debug(f"Exported {len(items)} items")
return

# If the response is a client error (4xx), we wont retry
Expand Down