Skip to content

Fixes #71: Added support for max_tokens in ModelSettings #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fixes #71: Added support for max_tokens in ModelSettings #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/agents/model_settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ class ModelSettings:
tool_choice: Literal["auto", "required", "none"] | str | None = None
parallel_tool_calls: bool | None = False
truncation: Literal["auto", "disabled"] | None = None
max_tokens: int | None = None

def resolve(self, override: ModelSettings | None) -> ModelSettings:
"""Produce a new ModelSettings by overlaying any non-None values from the
Expand All @@ -33,4 +34,5 @@ def resolve(self, override: ModelSettings | None) -> ModelSettings:
tool_choice=override.tool_choice or self.tool_choice,
parallel_tool_calls=override.parallel_tool_calls or self.parallel_tool_calls,
truncation=override.truncation or self.truncation,
max_tokens=override.max_tokens or self.max_tokens,
)
1 change: 1 addition & 0 deletions src/agents/models/openai_chatcompletions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,6 +509,7 @@ async def _fetch_response(
stream=stream,
stream_options={"include_usage": True} if stream else NOT_GIVEN,
extra_headers=_HEADERS,
max_tokens=self._non_null_or_not_given(model_settings.max_tokens),
)

if isinstance(ret, ChatCompletion):
Expand Down