removing ds store, adding gitignore #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
While you're here, can you remove the egg/pycache too? there are a bunch of pycache directories that slipped in |
rm-openai
approved these changes
Mar 11, 2025
rm-openai
pushed a commit
that referenced
this pull request
Mar 11, 2025
removing ds store, adding gitignore
DeanLuus22021994
pushed a commit
to DeanLuus22021994/openai-agents-python
that referenced
this pull request
Nov 8, 2025
…ocumentation MEDIUM PRIORITY openai#6, openai#7, openai#8: COMPLETED Volume Documentation: - Added cleanup column to volume table - Documented each volume's purpose and safety - Added volume management commands (view sizes, clean caches) - Marked dangerous operations (database volumes) - Provided docker-compose down -v cleanup instructions Health Check Documentation: - Added comprehensive health check table (interval, timeout, retries, start period) - Documented health check commands (ps, inspect, logs) - Provided tuning guidance for slower systems - Explained why app-dev has no health check (uses sleep infinity) GPU Support Documentation: - Comprehensive requirements section (hardware, drivers, Docker Desktop) - Configuration examples from docker-compose.yml - Verification commands (nvidia-smi, torch.cuda) - Troubleshooting guide: * WSL2 GPU support setup * Docker Desktop settings * Graceful CPU fallback * How to disable GPU reservation - Usage notes (optional, graceful degradation, performance benefits) All MEDIUM priority documentation items now complete!
DIZ-admin
pushed a commit
to DIZ-admin/openai-agents-python
that referenced
this pull request
Nov 18, 2025
Implemented immutable audit logging for PII detection: - PIIAuditTrail class with SQLite storage - PIIAuditRecord dataclass for audit entries - Automatic logging of all PII scans and blocking decisions - Retention policy enforcement (default: 90 days) - Query interface for investigations and reporting Features: - Immutable audit records (never modified after creation) - SHA-256 hashing of field values (never store actual PII) - Comprehensive metadata (session_id, timestamp, confidence, risk_level) - Detection method tracking (rule-based, ai-based, hybrid) - Blocking decision audit trail - Statistics and compliance reporting Integration: - Integrated into PIIDetector.scan_text() - Integrated into PIIDetector.should_block_processing() - Automatic logging on every PII scan - Session ID tracking for correlation - Image path tracking for context Database schema: - SQLite with indexed columns for fast queries - Indexes on: session_id, timestamp, blocked, risk_level - Automatic cleanup of old records - Export capabilities for compliance reports Benefits: - Full compliance with GDPR audit requirements - Transparent PII detection decisions - Investigation capabilities for false positives/negatives - Statistical analysis for model improvement - Retention policy enforcement Tests: - 10 comprehensive unit tests for audit trail - Test record creation, storage, retrieval - Test filtering by session, date, blocked status - Test cleanup and statistics - All audit trail tests passing (10/10) Note: Updated PIIDetector.should_block_processing() to async to support audit trail logging. Updated all call sites. Resolves: openai#8 (HIGH priority) Impact: Enables compliance and transparency for PII validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing DS_Store and adding gitignore