Skip to content

Bugfix for reasoning-function-call notebook #1800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 30, 2025
Merged

Bugfix for reasoning-function-call notebook #1800

merged 8 commits into from
Apr 30, 2025

Conversation

tompakeman-oai
Copy link
Contributor

Summary

  • Small fix of broken error handling for function calls.
  • Old code would error in case of missing tool handler for the function

vhoudebine-openai
vhoudebine-openai approved these changes Apr 29, 2025
View reviewed changes
Copy link

@vhoudebine-openai vhoudebine-openai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tompakeman-oai tompakeman-oai merged commit cb43eb4 into main Apr 30, 2025
1 check passed
@tompakeman-oai tompakeman-oai deleted the tompakeman branch April 30, 2025 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vhoudebine-openai vhoudebine-openai vhoudebine-openai approved these changes

@pap-openai pap-openai Awaiting requested review from pap-openai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tompakeman-oai @vhoudebine-openai