Generate GetChatCompletionMessages with pagination #569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christothes
requested review from
ShivangiReja,
joseharriaga and
trrwilson
as code owners
src/Generated/ChatClientGetChatCompletionMessagesAsyncCollectionResult.cs
Outdated
Show resolved
Hide resolved
joseharriaga
requested changes
Jul 30, 2025
joseharriaga
approved these changes
Jul 31, 2025
| public ChatOutputAudio Audio { get; } | ||
| public string Content { get; } | ||
| public string Id { get; } | ||
| public string Refusal { get; } |
Collaborator
There was a problem hiding this comment.
Can be done in a separate PR: This class appears to be missing a few properties:
- content_parts
- function_call
- name
| public IReadOnlyList<ChatToolCall> ToolCalls { get; } | ||
|
|
||
| public IList<ChatMessageAnnotation> Annotations { get; } | ||
| public IReadOnlyList<ChatMessageAnnotation> Annotations { get; } |
Collaborator
There was a problem hiding this comment.
why is this readonly? messages are input models.
Collaborator
There was a problem hiding this comment.
This looks like a ChatMessage but it is not. It's a read-only representation of the chat messages corresponding to a stored chat completion. While they look very similar, they unfortunately have a few differences and hence we couldn't reuse the ChatMessage class. For now, we're introducing this class as experimental. I will share offline a few considerations that we have been discussing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #520