Skip to content

build: mark generator version automation script as succeeded with issues when there are errors #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2025
Merged

build: mark generator version automation script as succeeded with issues when there are errors #615

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions scripts/Submit-GeneratorUpdatePr.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ param(
)

# Set up variables for the PR
# Track if any warnings were encountered during execution
$WarningsEncountered = $false
$RepoOwner = "openai"
$RepoName = "openai-dotnet"
$BaseBranch = "main"
Expand All @@ -50,6 +52,8 @@ function Write-Log {
function Write-Warning-Log {
param([string]$Message)
Write-Host "$(Get-Date -Format 'yyyy-MM-dd HH:mm:ss'): WARNING: $Message" -ForegroundColor Yellow
# Set the global warning flag to track that warnings occurred
$script:WarningsEncountered = $true
}

function Write-Error-Log {
Expand Down Expand Up @@ -251,7 +255,11 @@ Update @typespec/http-client-csharp to $PackageVersion
Write-Log "Creating PR using GitHub CLI"
$env:GH_TOKEN = $AuthToken

# Update PR title if warnings were encountered
$prTitle = "Update @typespec/http-client-csharp to $PackageVersion"
if ($WarningsEncountered) {
$prTitle = "Succeeded with Issues: $prTitle"
}
$prBody = @"
This PR automatically updates the TypeSpec HTTP client C# generator version and regenerates the SDK code.

Expand Down Expand Up @@ -285,6 +293,12 @@ If there are any issues with the generated code, please review the [TypeSpec rel
}

Write-Log "Successfully created PR: $prUrl"
# If warnings were encountered, make the script exit with non-zero code
# This will mark the GitHub Action step as failed but still create the PR
if ($WarningsEncountered) {
Write-Warning-Log "Warnings were encountered during execution. PR was created but marking step as failed."
exit 1
}

} catch {
Write-Error-Log "Error creating PR: $_"
Expand Down