Add ResponseItem constructors
#625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public FileSearchCallResponseItem(IEnumerable<string> queries); | ||
| public IList<string> Queries { get; } | ||
| public IList<FileSearchCallResult> Results { get; } | ||
| public IList<FileSearchCallResult> Results { get; set; } |
Collaborator
There was a problem hiding this comment.
I believe we don't provide setter for collection properties? is it not the case here?
Collaborator
Author
There was a problem hiding this comment.
Yes, this is correct. See my comment in PR description. This is a limitation in our codegen, but since this is experimental, I don't think it should be a blocker. 🙂
src/Custom/Responses/Items/Internal/InternalResponsesAssistantMessage.cs
Outdated
Show resolved
Hide resolved
src/Custom/Responses/Items/Internal/InternalResponsesDeveloperMessage.cs
Outdated
Show resolved
Hide resolved
src/Custom/Responses/Items/Internal/InternalResponsesSystemMessage.cs
Outdated
Show resolved
Hide resolved
src/Custom/Responses/Items/Internal/InternalResponsesUserMessage.cs
Outdated
Show resolved
Hide resolved
joseharriaga
force-pushed
the
joseharriaga/ItemConstructors
branch
from
c10d11d to
c1b73b5
Compare
ShivangiReja
approved these changes
Aug 27, 2025
…ningSummaryTextPart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the classes derived from
ResponseItemnow have public constructors, and these constructors are generated.A side effect of making these classes behave as both, inputs and outputs, was that their required properties got setters. Setters make sense when the values of these properties can be updated, but in this particular case they should only be settable at construction time. This is a limitation in the code generator being tracked by the following issue:
🔗 microsoft/typespec#5175 (comment)