Skip to content

Add an internal RequestOptions-based overload for GenerateEmbeddingsAsync #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2025
Merged

Add an internal RequestOptions-based overload for GenerateEmbeddingsAsync #704

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/Custom/Embeddings/EmbeddingClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,15 +170,20 @@ public virtual ClientResult<OpenAIEmbedding> GenerateEmbedding(string input, Emb
/// <param name="cancellationToken"> A token that can be used to cancel this method call. </param>
/// <exception cref="ArgumentNullException"> <paramref name="inputs"/> is null. </exception>
/// <exception cref="ArgumentException"> <paramref name="inputs"/> is an empty collection, and was expected to be non-empty. </exception>
public virtual async Task<ClientResult<OpenAIEmbeddingCollection>> GenerateEmbeddingsAsync(IEnumerable<string> inputs, EmbeddingGenerationOptions options = null, CancellationToken cancellationToken = default)
public virtual Task<ClientResult<OpenAIEmbeddingCollection>> GenerateEmbeddingsAsync(IEnumerable<string> inputs, EmbeddingGenerationOptions options = null, CancellationToken cancellationToken = default)
{
return GenerateEmbeddingsAsync(inputs, options, cancellationToken.ToRequestOptions());
}

internal async Task<ClientResult<OpenAIEmbeddingCollection>> GenerateEmbeddingsAsync(IEnumerable<string> inputs, EmbeddingGenerationOptions options, RequestOptions requestOptions)
{
Argument.AssertNotNullOrEmpty(inputs, nameof(inputs));

options ??= new();
CreateEmbeddingGenerationOptions(inputs, ref options);

using BinaryContent content = options.ToBinaryContent();
ClientResult result = await GenerateEmbeddingsAsync(content, cancellationToken.ToRequestOptions()).ConfigureAwait(false);
ClientResult result = await GenerateEmbeddingsAsync(content, requestOptions).ConfigureAwait(false);
return ClientResult.FromValue((OpenAIEmbeddingCollection)result, result.GetRawResponse());

}
Expand Down