Update @typespec/http-client-csharp to 1.0.0-alpha.20251009.7 #742
Conversation
github-actions
bot
requested review from
ShivangiReja,
joseharriaga and
trrwilson
as code owners
- Updated @typespec/http-client-csharp from 1.0.0-alpha.20251003.1 to 1.0.0-alpha.20251003.2 - Updated Microsoft.TypeSpec.Generator.ClientModel from 1.0.0-alpha.20251003.1 to 1.0.0-alpha.20251003.2 - Regenerated OpenAI SDK code with new generator version - Updated centrally managed package-lock.json file with new dependency versions
jorgerangel-msft
force-pushed
the
typespec/update-http-client-csharp-1.0.0-alpha.20251003.2
branch
from
d31cf92 to
6b467cd
Compare
jorgerangel-msft
changed the title
| public DateTimeOffset ExpiresAt { get; } | ||
|
|
||
| public string Object { get; } | ||
| internal InternalUploadObject? Object { get; } |
There was a problem hiding this comment.
I think we will need to customize this back to string
There was a problem hiding this comment.
The type is internal, is this just to maintain the previous behavior?
There was a problem hiding this comment.
Hmm maybe not necessary, but I noticed the serialization code changed as a result.
There was a problem hiding this comment.
I have yet to run the live tests, but I will try to validate this doesn't break anything if we change this to an enum.
There was a problem hiding this comment.
@JoshLove-msft - I ran the live tests and everything seems to be passing. Looking at the serialization code, it seems like it is functionally the same unless I'm missing something here?
There was a problem hiding this comment.
I missed that this was internal and the deserialization changes look to be functionally equivalent.
There was a problem hiding this comment.
I added a unit test that tests the round trip serialization of one of these models for sanity.
…ypespec/update-http-client-csharp-1.0.0-alpha.20251003.2
jorgerangel-msft
deleted the
typespec/update-http-client-csharp-1.0.0-alpha.20251003.2
branch
Updates the generator version to
1.0.0-alpha.20251009.7.fixes: microsoft/typespec#8710